Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "fix(optimizer): let the bundler handle entries" #7298

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

maiieul
Copy link
Contributor

@maiieul maiieul commented Jan 30, 2025

This reverts commit 568132c.

What is it?

  • Feature / enhancement
  • Bug
  • Docs / tests / types / typos
  • Infra

Description

Checklist

  • My code follows the developer guidelines of this project
  • I performed a self-review of my own code
  • I added a changeset with pnpm change
  • I made corresponding changes to the Qwik docs
  • I added new tests to cover the fix / functionality

@maiieul maiieul requested review from a team as code owners January 30, 2025 17:50
Copy link

changeset-bot bot commented Jan 30, 2025

⚠️ No Changeset found

Latest commit: cd37b1a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

pkg-pr-new bot commented Jan 30, 2025

Open in Stackblitz

npm i https://pkg.pr.new/@builder.io/qwik@7298
npm i https://pkg.pr.new/@builder.io/qwik-city@7298
npm i https://pkg.pr.new/eslint-plugin-qwik@7298
npm i https://pkg.pr.new/create-qwik@7298

commit: 489e5e9

Copy link
Contributor

github-actions bot commented Jan 30, 2025

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
qwik-docs ✅ Ready (View Log) Visit Preview 489e5e9

@wmertens
Copy link
Member

as stated on discord, it seems like the latest fixes make qwik.dev work well again so this may not be necessary, plus we have a bunch of changes in v2 that depend on these changes, and it will be extra work to maintain two codebases.

@maiieul maiieul marked this pull request as draft January 31, 2025 17:12
@maiieul maiieul force-pushed the revert-568123c-let-the-bundler-handle-entries branch from cd37b1a to 489e5e9 Compare February 1, 2025 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants