.github/workflows/release-test.yml: Fix upload-artifact #21142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new upload artifact does not support multiple artifacts uploaded with the same name, this fixes this by adding matrix info in
github-actions
bot
added
the
Area: CI
|
Here are the fix results... Not so nice with the whitespace but it works 😅 |
MrKevinWeiss
added
CI: skip compile test
chrysn
reviewed
Jan 20, 2025
| @@ -184,5 +184,5 @@ jobs: | |||
| - uses: actions/upload-artifact@v4 | |||
| if: always() | |||
| with: | |||
| name: Test Reports | |||
| name: Test-Reports-${{ matrix.pytest_mark }} | |||
There was a problem hiding this comment.
If spaces are fine, pytest_mark not iotlab_creds would probably cause trouble.
There was a problem hiding this comment.
nvm, you already mention the not-so-pretty situation in the earlier comment. It's GitHub action reports, it doesn't need to be pretty :-). It works, ship it.
chrysn
approved these changes
Jan 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
The new upload artifact does not support multiple artifacts uploaded with the same name, this fixes this by adding matrix info in.
Here is the current error
Testing procedure
Check the CI output.
Issues/PRs references