-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WiP: resolved some minor errors that raised from the initial clone of the branch #45
Draft
monoatamd
wants to merge
33
commits into
ROCm:feature/openacc-library-routines
Choose a base branch
from
monoatamd:feature/openacc-library-routines
base: feature/openacc-library-routines
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
33 commits
Select commit
Hold shift + click to select a range
ca701ff
resolved minor errors in forked repo
monoatamd 1fad76b
additional examples to test acc rtlib
monoatamd 08076e0
calling gpufortrt instead of acc
monoatamd 2929de3
deleted parts not compliant with gpufort
monoatamd c040997
fixed issue with acc_copy and gpufortrt_copy
monoatamd 1706325
Fixed incorrect templates for copy
monoatamd 3af85dc
acc_is_present impl. with type(*) and dimension
monoatamd 59d4293
avoided camelCase & added implicit none explicitly
monoatamd af7087e
minor update
monoatamd a69f450
fixed renaming conflict
monoatamd aa4c16a
added list of openacc rtlib routines
monoatamd 611c40f
Reverted frontend chngs, added impl. for 4 apis
monoatamd cfd4e14
added more high priority APIs
monoatamd 423d1ac
added more APIs
monoatamd 486acd3
added acc_get_property
monoatamd 081b5ec
added wait and async APIs
monoatamd e92324d
making APIs look identical to acc
monoatamd 750bda9
added copyin and copyout
monoatamd 0797f5f
Used sizeof instead of size to get num of bytes
monoatamd aa63276
added set and get default async
monoatamd 497afdf
added acc_create and test programs
monoatamd 927a09c
added acc_delete and a test program
monoatamd 71a809f
added acc_update/device and a test program
monoatamd 9da7378
added deviceptr and updated implementation_status
monoatamd bec8050
added acc_get_num_devices and a test program
monoatamd 0562abc
added gpufortrt_is_present and added test programs
monoatamd 26587db
LOG_ERROR updated in gpufortrt_is_present
monoatamd 84fb3fe
added acc_malloc and a test program
monoatamd 487f985
updated acc_malloc & test program, added acc_free
monoatamd 93abafa
added acc_map_data and a test program
monoatamd 3cad2b6
Remved templats & macros. use_device needs revison
monoatamd 246a629
added use_device
monoatamd 871c6b5
removed optional attrib. from non-optional args.
monoatamd File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -13,3 +13,4 @@ gpufort.h | |
gpufort_reductions.h | ||
render*.template.* | ||
render.py.in | ||
.vscode/settings.json |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,57 @@ | ||
--- | ||
geometry: margin=2cm | ||
--- | ||
|
||
# Implemented API | ||
|
||
| API | Lang\* | OpenACC | GPUFORTRT\*\* | Priority\*\*\* | | ||
|-----|--------|---------|-------------|----------| | ||
|acc\_get\_num\_devices|C/C++, Fortran|implemented|implemented|high| | ||
|acc\_set\_device\_type|C/C++, Fortran|implemented|implemented|high| | ||
|acc\_get\_device\_type|C/C++, Fortran|implemented|implemented|high| | ||
|acc\_set\_device\_num|C/C++, Fortran|implemented|implemented|| | ||
|acc\_get\_device\_num|C/C++, Fortran|implemented|implemented|| | ||
|acc\_get\_property|C/C++, Fortran|implemented|implemented|| | ||
|acc\_init|C/C++, Fortran|implemented|implemented|| | ||
|acc\_shutdown|C/C++, Fortran|implemented|implemented|| | ||
|acc\_async\_test|C/C++, Fortran|implemented|implemented|| | ||
|acc\_async\_test\_device|C/C++, Fortran|implemented|implemented|| | ||
|acc\_async\_test\_all|C/C++, Fortran|implemented|implemented|| | ||
|acc\_async\_test\_all\_device|C/C++, Fortran|implemented|implemented|| | ||
|acc\_wait|C/C++, Fortran|implemented|implemented|| | ||
|acc\_wait\_device|C/C++, Fortran|implemented|implemented|high| | ||
|acc\_wait\_async|C/C++, Fortran|implemented|implemented|| | ||
|acc\_wait\_device\_async|C/C++, Fortran|implemented|implemented|high| | ||
|acc\_wait\_all|C/C++, Fortran|implemented|implemented|| | ||
|acc\_wait\_all\_device|C/C++, Fortran|implemented|implemented|high| | ||
|acc\_wait\_all\_async|C/C++, Fortran|implemented|implemented|| | ||
|acc\_wait\_all\_device\_async|C/C++, Fortran|implemented|implemented|high| | ||
|acc\_get\_default\_async|C/C++, Fortran|implemented|implemented|| | ||
|acc\_set\_default\_async|C/C++, Fortran|implemented|implemented|| | ||
|acc\_on\_device||||low| | ||
|acc\_malloc||||low| | ||
|acc\_free||||low| | ||
|acc\_copyin|C/C++, Fortran|implemented|implemented|| | ||
|acc\_create|C/C++, Fortran|implemented|implemented|| | ||
|acc\_copyout|C/C++, Fortran|implemented|implemented|| | ||
|acc\_delete|C/C++, Fortran|implemented|implemented|| | ||
|acc\_update\_device|C/C++, Fortran|implemented|implemented|| | ||
|acc\_update\_self|C/C++, Fortran|implemented|implemented|| | ||
|acc\_map\_data||||low| | ||
|acc\_unmap\_data||||low| | ||
|acc\_deviceptr|C/C++||implemented|| | ||
|acc\_hostptr|C/C++|||low| | ||
|acc\_is\_present|||implemented|| | ||
|acc\_memcpy\_to\_device||||low| | ||
|acc\_memcpy\_from\_device||||low| | ||
|acc\_memcpy\_device||||low| | ||
|acc\_attach||||low| | ||
|acc\_detach||||low| | ||
|acc\_memcpy\_d2d||||low| | ||
|
||
Remarks: | ||
|
||
* \* While some APIs are exposed only to C according to the OpenACC standard, `GPUFORTRT` may expose some C interfaces also to Fortran. An \* indicates that this feature was exposed by the GPUFORTRT to Fortran despite the OpenACC standard not requiring this. | ||
* \*\* `GPUFORTRT` signatures are prefixd by `gpufortrt_` instead of `acc_` and the number and meaning of | ||
arguments may differ compared to the OpenACC signature. | ||
* \*\*\* Current priorities for implementing missing APIs. This column will disappear as soon as all are implemented. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Won't accept frontend changes now as I am currently changing it on a separate development branch.
I suggest to keep a local copy and not include to this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please feel free to reject the changes. I have local copies.