Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quickstart changes: native install needs to wget amdgpu_install deb or rpm, to get .list files #39

Merged
merged 1 commit into from
Jan 9, 2024

Conversation

yhuiYH
Copy link
Collaborator

@yhuiYH yhuiYH commented Jan 5, 2024

Quickstart Install changes:

  • Native install needs to put back the wget of amdgpu_install deb or rpm (revert of Correct quick start guide #24). That is how the repo.list files get on the system, otherwise native install just fails.
  • AMDGPU-install should re-add graphics to usecases.
  • I switched the panel order to show Native first, then AMDGPU as second, to flow with page layout
  • In native install, sudo apt install rocm-hip-libraries can be changed to sudo apt install rocm now, but needs more testing first.

@pramenku
Copy link
Contributor

pramenku commented Jan 6, 2024

Quickstart Install changes:

  • Native install needs to put back the wget of amdgpu_install deb or rpm. That is how the repo.list files get on the system, otherwise native install just fails.
  • AMDGPU-install should re-add graphics to usecases.
  • I switched the panel order to show Native first, then AMDGPU as second, to flow with page layout
  • In native install, sudo apt install rocm-hip-libraries can be changed to sudo apt install rocm now, but needs more testing first.

Added few points

#1. Earlier missed steps to add the repo.
Better we should not mix Native and Installer method. Both are two different approach so we should be documenting that way.
User should see the difference in approach and use as per their need.

If user already installing installer then why will do apt install instead they will directly do amdgpu-install --usecase=rocm

Main intention is that both should be having clear difference.

Previously, for Native, we used to add repo like below which clearly shows the difference in the two approaches.

sudo tee /etc/apt/sources.list.d/amdgpu.list <<'EOF'
deb [arch=amd64 signed-by=/etc/apt/keyrings/rocm.gpg] https://repo.radeon.com/amdgpu/latest/ubuntu jammy main
EOF

sudo tee /etc/apt/sources.list.d/rocm.list <<'EOF'
deb [arch=amd64 signed-by=/etc/apt/keyrings/rocm.gpg] https://repo.radeon.com/rocm/apt/debian jammy main
EOF

#2. This doc for ROCm so not sure why we want to add graphics usecase in rocm doc page.
Already, GFX Team adding graphics usecase in their GFX release documentation
For ROCm user, graphics usecase is just extra installation.

If we are planning as Unified Stack documentation, then I understand and we can add all different usercases for the user.

#4. That can be done when "rocm" meta package is planned for any release and it hasn't been tested in 6.0.
Not sure installer has this meta package enabled or not so better let's get all places updated.

@pramenku pramenku requested a review from nunnikri January 8, 2024 05:35
@yhuiYH
Copy link
Collaborator Author

yhuiYH commented Jan 8, 2024

Added few points

#1. Earlier missed steps to add the repo. Better we should not mix Native and Installer method. Both are two different approach so we should be documenting that way. User should see the difference in approach and use as per their need.

If user already installing installer then why will do apt install instead they will directly do amdgpu-install --usecase=rocm

Main intention is that both should be having clear difference.

Previously, for Native, we used to add repo like below which clearly shows the difference in the two approaches.

sudo tee /etc/apt/sources.list.d/amdgpu.list <<'EOF' deb [arch=amd64 signed-by=/etc/apt/keyrings/rocm.gpg] https://repo.radeon.com/amdgpu/latest/ubuntu jammy main EOF

sudo tee /etc/apt/sources.list.d/rocm.list <<'EOF' deb [arch=amd64 signed-by=/etc/apt/keyrings/rocm.gpg] https://repo.radeon.com/rocm/apt/debian jammy main EOF

#2. This doc for ROCm so not sure why we want to add graphics usecase in rocm doc page. Already, GFX Team adding graphics usecase in their GFX release documentation For ROCm user, graphics usecase is just extra installation.

If we are planning as Unified Stack documentation, then I understand and we can add all different usercases for the user.

#4. That can be done when "rocm" meta package is planned for any release and it hasn't been tested in 6.0. Not sure installer has this meta package enabled or not so better let's get all places updated.

We want to simplify the quickstart instructions.

  1. For this change, we put out a goal to simply the instructions.
    • We WANT to remove the ‘tee’ instruction lines because it’s too messy to show the user.
    • Initially, we created another package to install the .list files. But we had a discussion with Nirmal and Freddy in Oct/Nov 2023 and they recommended to just install the amdgpu-install package, then call native package manager. It will save from maintaining another simple package that amdgpu-install already does.
    • Another benefit to using ‘apt install’ is that it is built into the linux distros and you can uninstall nicely. It’s what native linux users are used to and may want to use. That’s why we added this case and think it should be the more preferred case for users because it is more standard Linux. People just know to use their package manager to install/remove packages.
    • We always get compared to NVIDIA. Look how simple the cuda quick-start instructions are (they just use apt-get, the standard package manager method built into the OS https://developer.nvidia.com/cuda-downloads?target_os=Linux&target_arch=x86_64&Distribution=Ubuntu&target_version=22.04&target_type=deb_network)

In summary, I think we still need to put back the wget/install amdgpu-install package for these instructions. Right now, it's just broken and doesn't work.

  1. Yes, I get your point about the document being ROCm centric. However, it’s a Quickstart guide, and to get people started quickly, sometimes, it’s just easier to install both “graphics,rocm”. However, your point is valid and debatable. Let me get some more opinions on it.

For "rocm" meta package, agree, after it is planned for release and tested.

@saadrahim
Copy link
Member

saadrahim commented Jan 8, 2024

Hi,
@yhuiYH please plan to add the new installation package as we planned earlier. A request for that will come formally later this week.

Initially, we created another package to install the .list files. But we had a discussion with Nirmal and Freddy in Oct/Nov 2023 and they recommended to just install the amdgpu-install package, then call native package manager. It will save from maintaining another simple package that amdgpu-install already does.

@yhuiYH yhuiYH merged commit 8d12f35 into develop Jan 9, 2024
1 of 2 checks passed
@yhuiYH yhuiYH deleted the amd/dev/yhui/fixLinuxQuickstart branch January 9, 2024 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants