Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cleanup #97

Merged
merged 3 commits into from
Mar 19, 2024
Merged

cleanup #97

merged 3 commits into from
Mar 19, 2024

Conversation

LisaDelaney
Copy link
Contributor

@LisaDelaney LisaDelaney commented Mar 18, 2024 •
edited
Loading

edits for #91

Lisa Delaney added 2 commits March 18, 2024 09:49
@LisaDelaney LisaDelaney marked this pull request as ready for review March 18, 2024 16:16
@LisaDelaney LisaDelaney requested a review from a team as a code owner March 18, 2024 16:16
@LisaDelaney LisaDelaney requested review from yhuiYH and loggrado March 18, 2024 16:38
loggrado
loggrado approved these changes Mar 19, 2024
View reviewed changes
Copy link
Contributor

@loggrado loggrado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one fix for the base README

@LisaDelaney @loggrado
Update README.md
9c4556d 
Co-authored-by: Logan Grado <[email protected]>
@LisaDelaney LisaDelaney merged commit 9af3fca into ROCm:basic_formatting Mar 19, 2024
1 check passed
@LisaDelaney LisaDelaney deleted the basic_formatting branch March 19, 2024 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@loggrado loggrado loggrado approved these changes

@yhuiYH yhuiYH Awaiting requested review from yhuiYH

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LisaDelaney @loggrado