Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmake: try system libraries first #71

Merged
merged 1 commit into from
Sep 14, 2024
Merged

cmake: try system libraries first #71

merged 1 commit into from
Sep 14, 2024

Conversation

abouvier
Copy link
Contributor

@abouvier abouvier commented Sep 6, 2024

Give package managers a chance :p

@abouvier abouvier marked this pull request as draft September 6, 2024 01:59
@abouvier abouvier force-pushed the cmake-unbundle2 branch 2 times, most recently from 7f35150 to 0f33406 Compare September 6, 2024 02:07
@abouvier abouvier marked this pull request as ready for review September 6, 2024 02:13
DHrpcs3
DHrpcs3 requested changes Sep 7, 2024
View reviewed changes
Copy link
Contributor

@DHrpcs3 DHrpcs3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for cleanup. Probably we can apply sox and unwind changes, but not SPIRV

CMakeLists.txt Outdated Show resolved Hide resolved
CMakeLists.txt Outdated Show resolved Hide resolved
DHrpcs3
DHrpcs3 reviewed Sep 8, 2024
View reviewed changes
Copy link
Contributor

@DHrpcs3 DHrpcs3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, seems it works for me, thank you
Regarding SPIRV-Tools, could you please investigate how we can determine that latest 2 commits from following repository is included to precompiled library?
https://github.com/RPCSX/SPIRV-Tools/commits/main/

cmake/FindSPIRV-Cross.cmake Show resolved Hide resolved
@abouvier
Copy link
Contributor Author

abouvier commented Sep 8, 2024

OK, seems it works for me, thank you Regarding SPIRV-Tools, could you please investigate how we can determine that latest 2 commits from following repository is included to precompiled library? https://github.com/RPCSX/SPIRV-Tools/commits/main/

I added a check for the presence of spvtools::CreateBitCastCombinePass, but the other commit does not change the public API. How can a program use the new functions?

@DHrpcs3
Copy link
Contributor

DHrpcs3 commented Sep 14, 2024

OK, seems it works for me, thank you Regarding SPIRV-Tools, could you please investigate how we can determine that latest 2 commits from following repository is included to precompiled library? https://github.com/RPCSX/SPIRV-Tools/commits/main/

I added a check for the presence of spvtools::CreateBitCastCombinePass, but the other commit does not change the public API. How can a program use the new functions?

They shouldn't be used explicitly, it extends already exists optimization pipeline

@DHrpcs3 DHrpcs3 merged commit 7e78907 into RPCSX:master Sep 14, 2024
1 of 3 checks passed
@DHrpcs3
Copy link
Contributor

DHrpcs3 commented Sep 14, 2024

Looks good now, thank you

@abouvier abouvier deleted the cmake-unbundle2 branch September 14, 2024 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DHrpcs3 DHrpcs3 DHrpcs3 requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@abouvier @DHrpcs3