Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FAIR4RS training page #804

Merged
merged 20 commits into from
Sep 9, 2024
Merged

Add FAIR4RS training page #804

merged 20 commits into from
Sep 9, 2024

Conversation

tdjames1
Copy link
Contributor

@tdjames1 tdjames1 commented Sep 9, 2024

New page containing course description and preliminary details for FAIR4RS training course.

@tdjames1 tdjames1 requested a review from a team September 9, 2024 14:26
Copy link
Member

@Robadob Robadob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two typos, rest are small subjective/typographic suggestions.

pages/training/fair4rs/index.md Outdated Show resolved Hide resolved
single human that would not forget what they have done before. But what if one generation of researcher stops sharing
how they are doing their work? Research will stall. It is therefore the duty of each generation of researchers, to allow
the next one to take over in the most efficient way possible. In the age of digital research data-driven discovery,
sharing research can not be limited to publishing results on academic papers only. This is role of the Open Science
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
sharing research can not be limited to publishing results on academic papers only. This is role of the Open Science
sharing research can not be limited to publishing results in academic papers only. This is role of the Open Science

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This suggestion got missed because @ns-rse made a suggestion in the same line.

pages/training/fair4rs/index.md Outdated Show resolved Hide resolved
pages/training/fair4rs/index.md Outdated Show resolved Hide resolved
pages/training/fair4rs/index.md Outdated Show resolved Hide resolved
### Outline of the program

<div class="alert alert-info"> <strong>Info!</strong> The definitive program (with dates and registration links) will be
online on Oct 1st.</div>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe worth summarising the form the different events will take, I was surprised first was a lunchbytes seminar, I had assumed all were more carpentries-ey.

#### Software design
<!-- (Romain Thomas) -->

The way you write your code will have a massive impact on how easy it is to maintain. During this course we will try to
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

During this course we will try to understand how to create maintainable, readable and reusable code.

we will try to understand

Doesn't really read right/make sense


<!-- (Sylvia Whittle) -->

This course aims to equip researchers with the skills to write effective tests and ensure the quality and reliability of
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd probably mention the fact it's unit testing by name, incase someone has specifically been told unit testing.

pages/training/fair4rs/index.md Outdated Show resolved Hide resolved

[^1]: Wilkinson et al., ‘The FAIR Guiding Principles for Scientific Data Management and Stewardship’.
[^2]: Barker et al., ‘Introducing the FAIR Principles for Research Software’.
[^3]: Barker et al., ‘Introducing the FAIR Principles for Research Software’.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same reference twice, could merge.

Copy link
Contributor

@ns-rse ns-rse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some very minor points/suggestions but reads well, covers everything with a broad overview at the start before going into depth.

pages/training/fair4rs/index.md Outdated Show resolved Hide resolved
pages/training/fair4rs/index.md Outdated Show resolved Hide resolved
pages/training/fair4rs/index.md Outdated Show resolved Hide resolved
overview of the topics that are offered in more detail in additional modules, which can be selected according to an
individual’s learning goals.

This course is aimed at researchers, including PhDs and postgraduate research students, who create code (whether a few
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
This course is aimed at researchers, including PhDs and postgraduate research students, who create code (whether a few
This course is aimed at all researchers, including PhDs and postgraduate research students, research assistants, associate and professors, who create code (whether a few

Perhaps overkill being so explicit. 🤔

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

from PhDs to professors would do the same job.

pages/training/fair4rs/index.md Outdated Show resolved Hide resolved
testing using Python's Pytest framework, a powerful and beginner-friendly tool. You'll also learn how to integrate
automated testing into your development workflow using continuous integration (CI). CI streamlines your process by
automatically running tests with every code change, catching bugs early and saving you time.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

markdownlint-cli2 would I think complain about double line space here (there is a PR out #701 to integrate it into this repository but its been lingering for some time and not sure if it will be merged).

pages/training/fair4rs/index.md Outdated Show resolved Hide resolved
pages/training/fair4rs/index.md Outdated Show resolved Hide resolved
pages/training/fair4rs/index.md Outdated Show resolved Hide resolved
pages/training/fair4rs/index.md Outdated Show resolved Hide resolved
tdjames1 and others added 5 commits September 9, 2024 17:40
Co-authored-by: Robert Chisholm <[email protected]>
Co-authored-by: Neil Shephard <[email protected]>
@tdjames1
Copy link
Contributor Author

tdjames1 commented Sep 9, 2024

Thanks for the suggestions @Robadob and @ns-rse. Committed or commented on most of them. @Robadob there was one line where you had made two valid suggestions but it didn't let me commit both, so might need to re-suggest. There are several program -> programme substitutions still to do but I can't commit while pending review!

@Robadob
Copy link
Member

Robadob commented Sep 9, 2024

but it didn't let me commit both, so might need to re-suggest.

If this is the 'a la carte' one, it was intended as an either/or, not both. Otherwise lmk what I need to fix.

including commercialisation
- Apply best practices for scientific software development including design, version control, testing, continuous
integration and documentation
- Associate their research software with a unique and persistent identifier and use metadata to enhance its findability,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not going to add since would then have to gloss the acronym.

pages/training/fair4rs/index.md Outdated Show resolved Hide resolved
pages/training/fair4rs/index.md Outdated Show resolved Hide resolved
single human that would not forget what they have done before. But what if one generation of researcher stops sharing
how they are doing their work? Research will stall. It is therefore the duty of each generation of researchers, to allow
the next one to take over in the most efficient way possible. In the age of digital research data-driven discovery,
sharing research can not be limited to publishing results on academic papers only. This is role of the Open Science
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This suggestion got missed because @ns-rse made a suggestion in the same line.

modern research. In the RSE team, we are ideally placed to witness that software is used in all research domains, from
physical sciences, to psychology or humanities. Some of these software tools are used to collect data from medical
patients, others are used to run complex simulations of merging galaxies. Software is an inherent part of research and
allows researchers to push boundaries of what still was impossible few years ago. Software often holds the key to the
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This suggestion got missed because of your other suggestion on the same line.

@tdjames1
Copy link
Contributor Author

tdjames1 commented Sep 9, 2024

@Robadob @ns-rse I've fixed the lines that I mentioned, so I think it's ready to go now...

@Robadob
Copy link
Member

Robadob commented Sep 9, 2024

Already approved by me, or did you want me to read through it a second time?

@tdjames1
Copy link
Contributor Author

tdjames1 commented Sep 9, 2024

@Robadob that's ok, I think I need @ns-rse to approve as he requested changes.

Copy link
Contributor

@ns-rse ns-rse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You blasted through all those suggestions @tdjames1 gets the 👍 from me, apologies for the delay in checking back in.

@tdjames1 tdjames1 merged commit 4122f56 into master Sep 9, 2024
2 checks passed
@tdjames1 tdjames1 deleted the tdj/fair4rs branch September 9, 2024 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants