[TikTokBridge] Use oEmbed for video metadata #4514
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fetches oEmbed-formatted metadata for videos through the TikTok API to provide post titles, thumbnails, and authors. This hasn't yet been tested, so it's possible it doesn't work.
Pull request artifacts
last change: Sunday 2025-05-04 15:54:49 |
|
I've been running with this patch on my instance for a little while, and it looks like the TikTok oEmbed API actually occasionally returns 400 bad request, even with a valid URL. I'll investigate this a bit more, and try to implement a fix (I figure I can probably just check if the request is successful and, in the case that it is not, just retry a few times, since it seems to work fine after re-sending the request). Here's the error output if anyone's interested. |
|
ok cool |
The non-www URL resulted in a 301 redirect to the www URL, so this just skips that redirect, improving performance a bit and hopefully helping with the 400 errors.
If an OEmbed request fails, retry a few times, waiting a bit in between each retry. This should fix the problem for the most part, since I think the problem was related to some sort of rate limit (it isn't mentioned in the docs, but it seems to only happen when sending large quantities of sequential requests).
|
I added some retry logic, and it seems to be working pretty consistently now (I wrote that patch about a week ago, and I don't think it's happened since - my RSS aggregator is fetching 6 TikTok feeds every ~15 minutes, so it was happening about once every 1.5 days before). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fetches oEmbed-formatted metadata for videos through the TikTok API to provide post titles, thumbnails, and authors. I'm not caching JSON responses so it has the potential to be a bit slow in theory, but in my testing this doesn't appear to cause any noticeable performance issues (I'm not super familiar with PHP so I'm not entirely sure how to add this if it is needed).