Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: enable noUncheckedIndexedAccess, better type check #2608

Merged
merged 6 commits into from
Jan 18, 2025
Merged

Conversation

hyoban
Copy link
Member

@hyoban hyoban commented Jan 18, 2025

Description

PR Type

  • Feature
  • Bugfix
  • Hotfix
  • Other (please describe):

Screenshots (if UI change)

Demo Video (if new feature)

Linked Issues

Additional context

Changelog

  • I have updated the changelog/next.md with my changes.

Copy link

linear bot commented Jan 18, 2025

Copy link

vercel bot commented Jan 18, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
follow ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 18, 2025 2:36pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
follow-external-ssr ⬜️ Ignored (Inspect) Visit Preview Jan 18, 2025 2:36pm

@follow-reviewer-bot
Copy link

Suggested PR Title:

fix: improve type safety with non-null assertions

Change Summary:
Updated typings for better type safety in the application. Adjusted multiple files across main and mobile applications to ensure non-null assertions for potentially undefined values. Added @follow/types as a dev dependency, improved type checks, and minor adjustments to ensure consistent behavior. These changes enhance code reliability and maintainability.

Code Review:
No change requests necessary.

@hyoban hyoban marked this pull request as ready for review January 18, 2025 14:34
@hyoban hyoban merged commit 2cd1b5d into dev Jan 18, 2025
8 of 10 checks passed
@hyoban hyoban deleted the fol-1503 branch January 18, 2025 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant