Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(discover): implement localized search results #2623

Merged
merged 1 commit into from
Jan 21, 2025
Merged

Conversation

kovsu
Copy link
Contributor

@kovsu kovsu commented Jan 21, 2025

Description

PR Type

  • Feature
  • Bugfix
  • Hotfix
  • Other (please describe):

Screenshots (if UI change)

Demo Video (if new feature)

Linked Issues

Additional context

Changelog

  • I have updated the changelog/next.md with my changes.

@follow-reviewer-bot
Copy link

Thank you for your contribution. We will review it promptly.

Copy link

vercel bot commented Jan 21, 2025

@kovsu is attempting to deploy a commit to the RSS3 Team on Vercel.

A member of the Team first needs to authorize it.

@follow-reviewer-bot
Copy link

Suggested PR Title:

fix(i18n): update search results text for better clarity

Change Summary:
Refactored UI text for search results to use i18n translations. This includes adding dynamic support for singular, plural, and zero results cases in English and Chinese locales. The user feedback is now more informative based on the search results count.

Code Review:
No change requests necessary.

@hyoban hyoban merged commit 166e095 into RSSNext:dev Jan 21, 2025
3 of 6 checks passed
@follow-reviewer-bot
Copy link

Thank you @kovsu for your contribution! 🎉

Your pull request has been merged and we really appreciate your help in making this project better. We hope to see more contributions from you in the future! 💪

@kovsu kovsu deleted the feat-1 branch January 21, 2025 03:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants