Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bsp: cvitek: fix source command spelling in Kconfig #10035

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

KennethLiu61
Copy link
Contributor

[Problem Description]
The Kconfig file contained misspelled source commands:

  • "osource" instead of "source" for packages config inclusion
  • "rsource" instead of "source" for board config inclusion

[Root Cause]
Incorrect source command spelling breaks Kconfig processing:

  1. "osource" is not a valid Kconfig command
  2. "rsource" is not a valid Kconfig command
  3. These typos prevent proper configuration inheritance

[Solution]
Correct the source command spellings:

  • Change "osource" to standard "source" for packages
  • Change "rsource" to standard "source" for board
  • Maintain original configuration hierarchy

拉取/合并请求描述:(PR description)

[

为什么提交这份PR (why to submit this PR)

你的解决方案是什么 (what is your solution)

请提供验证的bsp和config (provide the config and bsp)

  • BSP:
  • .config:
  • action:

]

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality:

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确,包括缩进空格,命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • 没有垃圾代码,代码尽量精简,不包含#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的,并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 代码是高质量的 Code in this PR is of high quality
  • 已经使用formatting 等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification
  • 如果是新增bsp, 已经添加ci检查到.github/workflows/bsp_buildings.yml 详细请参考链接BSP自查

[Problem Description]
The Kconfig file contained misspelled source commands:
- "osource" instead of "source" for packages config inclusion
- "rsource" instead of "source" for board config inclusion

[Root Cause]
Incorrect source command spelling breaks Kconfig processing:
1. "osource" is not a valid Kconfig command
2. "rsource" is not a valid Kconfig command
3. These typos prevent proper configuration inheritance

[Solution]
Correct the source command spellings:
- Change "osource" to standard "source" for packages
- Change "rsource" to standard "source" for board
- Maintain original configuration hierarchy

Signed-off-by: Liu Gui <[email protected]>
@github-actions github-actions bot added BSP BSP: Cvitek BSP related with cvitek labels Feb 25, 2025
@unicornx
Copy link
Contributor

osourc 和 rsource 也是合法的命令吧,见 https://pypi.org/project/kconfiglib/#library-documentation

image

我觉得原来的写法没有问题呢。

@unicornx
Copy link
Contributor

如果没有问题请 close 这个 PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BSP: Cvitek BSP related with cvitek BSP
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants