Messagebox #62
Open
Messagebox #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
mauroservienti
requested changes
Jan 19, 2019
src/net40/Radical.Windows.Presentation/Messaging/Handlers/ShowMessageBoxRequestHandler.cs
Outdated
Show resolved
Hide resolved
src/net40/Radical.Windows.Presentation/Messaging/Handlers/ShowMessageBoxRequestHandler.cs
Outdated
Show resolved
Hide resolved
src/net40/Radical.Windows.Presentation/Messaging/Handlers/ShowMessageBoxRequestHandler.cs
Outdated
Show resolved
Hide resolved
src/net40/Radical.Windows.Presentation/Messaging/Handlers/ShowMessageBoxRequestHandler.cs
Outdated
Show resolved
Hide resolved
src/net40/Radical.Windows.Presentation/Messaging/Handlers/ShowMessageBoxRequestHandler.cs
Outdated
Show resolved
Hide resolved
src/net40/Radical.Windows.Presentation/Messaging/Handlers/ShowMessageBoxRequestHandler.cs
Outdated
Show resolved
Hide resolved
src/net40/Radical.Windows.Presentation/Messaging/Handlers/ShowMessageBoxRequestHandler.cs
Outdated
Show resolved
Hide resolved
src/net40/Radical.Windows.Presentation/Messaging/ShowMessageBoxResult.cs
Show resolved
Hide resolved
|
@mauroservienti done ! |
mauroservienti
requested changes
Jan 29, 2019
| /// <summary> | ||
| /// Return value for the Message Box Open Request | ||
| /// </summary> | ||
| public class ShowMessageBoxResult |
| /// <summary> | ||
| /// | ||
| /// </summary> | ||
| public Action<MessageBoxResult> MessageBoxClosed { get; set; } |
There was a problem hiding this comment.
rename this to OnMessageBoxClosed
| /// <param name="broker"></param> | ||
| public ShowMessageBoxRequestHandler(IMessageBroker broker) | ||
| { | ||
| Ensure.That(broker).Named(() => broker).IsNotNull(); |
There was a problem hiding this comment.
do not use the labda, it's too slow. Replace with .Named("broker") or better yet .Named(nameof(broker)).
| public MessageBoxOptions? Options { get; set; } | ||
|
|
||
| /// <summary> | ||
| /// |
There was a problem hiding this comment.
Missing documentation 😄
Message box closed callback, invoked when the message box is closed by the user.
|
This needs to be recreated in Radical.Windows as soon as RadicalFx/Radical.Windows#111 is merged |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the possibility to show a MessageBox from ViewModel with message
Related to #63