Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pwm issue #12

Closed
wants to merge 3 commits into from
Closed

Pwm issue #12

wants to merge 3 commits into from

Conversation

nascs
Copy link

@nascs nascs commented Feb 4, 2024

5a/5b/3c/cm3 pwm 都用 led 重新测了一遍，3c pin 19 那个 pwm15_m0 被 fan0 占用

@RadxaYuntian RadxaYuntian changed the base branch from master to 2.1 February 4, 2024 06:43
@RadxaYuntian RadxaYuntian changed the base branch from 2.1 to master February 4, 2024 06:44
RadxaYuntian
RadxaYuntian requested changes Feb 4, 2024
View reviewed changes
src/arm/radxa_rock_3c.c Show resolved Hide resolved
src/arm/radxa_rock_5a.c Outdated Show resolved Hide resolved
@RadxaYuntian
Copy link
Owner

所以是必须要加上这个pwm.pinmap才能使用pwm么？这个应该是在结构分配内存时自动赋0了吧？

@nascs
Copy link
Author

nascs commented Feb 4, 2024

所以是必须要加上这个pwm.pinmap才能使用pwm么？这个应该是在结构分配内存时自动赋0了吧？

上周， 看 ROCK 3C 的 pin 7 脚 pwm 无法使用，后面加上 pwm.pinmap 就能用，但是今天的情况就是加不加都能用，打印了 board->pins[pin].pwm.pinmap 默认会初始化为 0，所以应该是不加也行

@RadxaYuntian
Copy link
Owner

所以还是没搞清楚为什么pwm不行咯

@RadxaYuntian
Copy link
Owner

已有文件的顺序就别改了吧，回头可以单独弄一个formatting的PR，这里还是主要修复使用问题

RadxaYuntian
RadxaYuntian requested changes Mar 11, 2024
View reviewed changes
src/arm/radxa_rock_5a.c Outdated Show resolved Hide resolved
@RadxaYuntian
Copy link
Owner

这边也要处理啊

@nascs
Copy link
Author

nascs commented Mar 22, 2024

这边也要处理啊

等 ROCK PI E 的 PR 合并

@RadxaYuntian
Copy link
Owner

这两个不影响，你可以先改，然后rock pi e的合并了再rebase

@nascs
Copy link
Author

nascs commented Mar 22, 2024

这两个不影响，你可以先改，然后rock pi e的合并了再rebase

好的，下周一

@nascs
Copy link
Author

nascs commented Mar 25, 2024

这边也要处理啊

所有板子的顺序要不要再这一块处理了？

@RadxaYuntian
Copy link
Owner

你要弄就先有个单独的commit处理格式问题。

@nascs nascs requested a review from RadxaYuntian March 25, 2024 11:29
RadxaYuntian
RadxaYuntian requested changes Mar 25, 2024
View reviewed changes
Copy link
Owner

@RadxaYuntian RadxaYuntian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

应该是先改格式，然后在加入新代码。并且5a的修改需要添加的时候就是正确的顺序

@nascs nascs requested a review from RadxaYuntian March 26, 2024 08:14
RadxaYuntian
RadxaYuntian requested changes Mar 26, 2024
View reviewed changes
Copy link
Owner

@RadxaYuntian RadxaYuntian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

你这个添加或减少pwm后要把头文件的数量更新啊

src/arm/radxa_cm5_io.c Outdated Show resolved Hide resolved
RadxaYuntian
RadxaYuntian requested changes Mar 26, 2024
View reviewed changes
Copy link
Owner

@RadxaYuntian RadxaYuntian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pwm修正的两个提交合并一下，然后pwm初始化的提交消息就写fix而不是unified。okdo那边已经发现之前的初始化是有问题的

@nascs
Copy link
Author

nascs commented Mar 26, 2024

pwm修正的两个提交合并一下，然后pwm初始化的提交消息就写fix而不是unified。okdo那边已经发现之前的初始化是有问题的

指的是不加 pinmap 会有问题？

@RadxaYuntian
Copy link
Owner

这个可以提交给上游了

@nascs
Copy link
Author

nascs commented Apr 19, 2024

这个可以提交给上游了

#eclipse/pull/1129

@RadxaYuntian
Copy link
Owner

一般链接PR/issue是用eclipse/mraa#1129这样的格式，效果：eclipse#1129

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RadxaYuntian RadxaYuntian RadxaYuntian approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nascs @RadxaYuntian