Linters: Bring back removed linters: wastedassign #1672
Conversation
Signed-off-by: Shyamsundar Ranganathan <[email protected]>
exhaustruct is also in the disabled list, so this is just a cleanup of the commented linter Signed-off-by: Shyamsundar Ranganathan <[email protected]>
| @@ -566,7 +566,7 @@ func GetDRClusters(ctx context.Context, client client.Client, drPolicy *rmn.DRPo | |||
| func (r DRPlacementControlReconciler) updateObjectMetadata(ctx context.Context, | |||
| drpc *rmn.DRPlacementControl, placementObj client.Object, log logr.Logger, | |||
| ) error { | |||
| update := false | |||
| var update bool | |||
There was a problem hiding this comment.
What is the issue with the previous code? Both are valid Go code and should compile to the same thing. If not this should be a Go compiler bug.
Maybe we need to report a golangci-lint bug for this, the linter should not requiring changing such code.
There was a problem hiding this comment.
It is a wasted assignment as it is overwritten right after. The linter is for a code practice not a code error afaict. I do not see an issue with the same.
There was a problem hiding this comment.
There is already an issue this:
sanposhiho/wastedassign#39
There was a problem hiding this comment.
I think I did visit that issue, once addressed it may help. For now it is better to have the linter than not, so I suggest we do not wait for a resolution of that issue (which seems to be 2+ years old).
| s3SecretRef := corev1.SecretReference{Name: secretName, Namespace: secretNS} | ||
| object := &runtime.RawExtension{} |
There was a problem hiding this comment.
Here we replace pointer to object with nil - this makes sense if the intent of the code is to initialize the pointer only in some cases, so a good change.
No description provided.