[pull] 3.x from filamentphp:3.x #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
This reverts commit 1aa2ba1.
ImageEntry and ImageColumn documentation states that defaultImageUrl() is for displaying a placeholder image if one doesn't exist yet. But If $stateItem is a filled string that points to a location that does not exist in storage then getImageUrl() will return null due to the file not existing and by doing so no image is loaded into the browser even though we set a default placeholder. So by using the ?? operator in the branch where string is filled we make sure the browser loads an image whether it's the placeholder or the storage one. Sources: https://filamentphp.com/docs/3.x/tables/columns/image#adding-a-default-image-url https://filamentphp.com/docs/3.x/infolists/entries/image#adding-a-default-image-url
…fore-deleting Fix broken XLSX exports
…com:ralphjsmit/filament into rjs/prevent-catching-db-commit-side-effects
fix: $defaultImageUrl not loading when getImageUrl() is null
…mit-side-effects Prevent catching side-effects of database transactions being committed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.1)
Can you help keep this open source service alive? 💖 Please sponsor : )