Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add social links #1294

Merged
merged 38 commits into from
Mar 13, 2024
Merged

feat: add social links #1294

merged 38 commits into from
Mar 13, 2024

Conversation

BenjaminHalko
Copy link
Member

Added social links with icons from DevSrSouza/compose-icons

Screenshot_20230921-155615_ReVanced Manager Debug

@BenjaminHalko BenjaminHalko added the ReVanced Manager Compose Regarding the Compose rewrite of ReVanced Manager label Sep 21, 2023
@oSumAtrIX oSumAtrIX mentioned this pull request Sep 29, 2023
Closed
@oSumAtrIX oSumAtrIX mentioned this pull request Oct 10, 2023
Merged
@BenjaminHalko BenjaminHalko marked this pull request as draft November 1, 2023 19:23
@BenjaminHalko
Copy link
Member Author

Screenshot_20231104-092538_ReVanced Manager Debug

@BenjaminHalko BenjaminHalko marked this pull request as ready for review November 4, 2023 16:28
Axelen123
Axelen123 requested changes Nov 4, 2023
View reviewed changes
app/build.gradle.kts Outdated Show resolved Hide resolved
app/build.gradle.kts Outdated Show resolved Hide resolved
app/src/main/java/app/revanced/manager/ui/screen/settings/AboutSettingsScreen.kt Outdated Show resolved Hide resolved
@Axelen123
Copy link
Member

@BenjaminHalko what is the status of this?

@BenjaminHalko
Copy link
Member Author

Sorry about the wait, it's on my backlog of things to finish...

@BenjaminHalko
Copy link
Member Author

I think it is finally done.

@BenjaminHalko
Copy link
Member Author

Screenshot_20240124-094455_ReVanced Manager Debug

@Ushie
Copy link
Member

Ushie commented Jan 24, 2024

Is there anyway to stop the Filled Buttons from taking all the available width? it looks odd

@BenjaminHalko
Copy link
Member Author

We could always increase the side padding, but there is no way to make it use the minimum space possible while also having the buttons be the same size. The fact that the buttons were the same size before was just a coincidence.

@oSumAtrIX oSumAtrIX requested review from Ushie and Axelen123 January 25, 2024 17:50
@BenjaminHalko
Copy link
Member Author

Ok it might be done now...

@BenjaminHalko BenjaminHalko merged commit 8d5d86f into ReVanced:compose-dev Mar 13, 2024
2 checks passed
@BenjaminHalko BenjaminHalko deleted the social-links branch March 13, 2024 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@validcube validcube validcube left review comments

@Axelen123 Axelen123 Axelen123 approved these changes

@oSumAtrIX oSumAtrIX oSumAtrIX approved these changes

@Aunali321 Aunali321 Awaiting requested review from Aunali321

@Ushie Ushie Awaiting requested review from Ushie

Assignees
No one assigned
Labels
ReVanced Manager Compose Regarding the Compose rewrite of ReVanced Manager
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@BenjaminHalko @Axelen123 @oSumAtrIX @Ushie @validcube