feat(Update Screen): Use BottomAppBar instead of a Header #2398
+74
−95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ushie
added
the
ReVanced Manager Compose
|
Should I move the ProgressIndicator to the top of the screen like the Patcher screen? Or should I move the PatcherScreen's down? |
|
Top is the expected location |
|
|
|
Move the total MBs downloaded on the top (top-right to be precise) as well. The current position don't have much sense. |
4 tasks
|
Currently it feel awkward having the progress indicator at the top, and total download at the bottom. I'd suggest removing the total download since progress indicator is enough or use @0xrxL's suggestion. |
|
Agreeing to both comments above. The bottom bar is not really conventional, can be moved to the top as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.