Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dockerfile simplification #10

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

frenzymadness
Copy link

When talking about your Dockefile this morning with @petracihalova, we realized that it might be simplified.

  • You don't need yum-utils just to add a repository.
  • Full-blown git is probably overkill, git-core should be enough.
  • Builds fine even without weak dependencies.

Copy link

@casey-williams-rh casey-williams-rh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

  • Adds package repo to yum without yum-utils
  • Replace git package with git-core
  • Disable Weak Dependencies

@petracihalova
Copy link

@dagbay-rh @casey-williams-rh how to proceed? I mean who can run awaiting workflows? how this works? thank you

@frenzymadness
Copy link
Author

The error preventing the image from building is:

error: Error running transaction: file /usr/local/openresty/bin/resty conflicts between attempted installs of openresty-resty-1.19.3-23.el8.noarch and openresty-1.21.4-1.el8.x86_64

The problem is caused by the conflict between openresty-resty version 1.19.3 which is explicitly required in the Dockerfile and newer version of one dependency openresty-1.21.4 which is not required explicitly and therefore installed in the newest possible version.

I pushed the fix which pins the same version of openresty.

@app-sre-bot
Copy link

Can one of the admins verify this patch?

@dagbay-rh
Copy link

I think my merging of the upstream repo created conflicts.... sorry 😿

@frenzymadness
Copy link
Author

Rebased

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants