Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add UI adjustments #91

Open
wants to merge 14 commits into
base: master
Choose a base branch
from
Open

Add UI adjustments #91

wants to merge 14 commits into from

Conversation

JetyAdam
Copy link
Contributor

@JetyAdam JetyAdam commented Dec 18, 2024 •
edited
Loading

@JetyAdam JetyAdam requested a review from a team December 18, 2024 13:42
@JetyAdam JetyAdam force-pushed the UI-review branch 2 times, most recently from 97561ca to e04119f Compare December 18, 2024 15:54
@Hyperkid123
Copy link
Contributor

/retest

Hyperkid123
Hyperkid123 reviewed Jan 2, 2025
View reviewed changes
Copy link
Contributor

@Hyperkid123 Hyperkid123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a couple more things:

  1. We are missing empty state if no content matches the filters:
  2. The content fallback skeletons use pf v4 spacing classname so the padding is not applied.
    screenshot-stage_foo_redhat_com_1337-2025_01_02-10_20_37

screenshot-stage_foo_redhat_com_1337-2025_01_02-10_19_35

src/components/GlobalLearningResourcesPage/AppliedFilters.tsx Outdated Show resolved Hide resolved
src/components/GlobalLearningResourcesPage/GlobalLearningResourcesFiltersCategoryMobile.tsx Outdated Show resolved Hide resolved
src/components/GlobalLearningResourcesPage/GlobalLearningResourcesFiltersMobile.tsx Outdated Show resolved Hide resolved
Hyperkid123
Hyperkid123 reviewed Jan 22, 2025
View reviewed changes
Copy link
Contributor

@Hyperkid123 Hyperkid123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see a lot of .map and compiled css files made it to the src directory. That is not something that should ever happen.

src/Creator.css Outdated Show resolved Hide resolved
src/Creator.css.map Outdated Show resolved Hide resolved
src/components/GlobalLearningResourcesPage/AppliedFilters.tsx Outdated Show resolved Hide resolved
@JetyAdam JetyAdam requested review from Hyperkid123, florkbr and a team January 24, 2025 20:54
@JetyAdam JetyAdam requested review from Hyperkid123 and a team January 31, 2025 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@florkbr florkbr Awaiting requested review from florkbr

@Hyperkid123 Hyperkid123 Awaiting requested review from Hyperkid123

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JetyAdam @Hyperkid123