-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lburnett/hbi event translation #4152
Draft
lindseyburnett
wants to merge
34
commits into
main
Choose a base branch
from
lburnett/hbi-event-translation
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
+5,497
−40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NOTE: HostGuestRepository stubbed out until implementation lands
When HBI event messages are received, filter them to ensure that we do not process any that define a billing_model of 'marketplace' or a host_type of 'edge'. This filter mimics the query currently being made to fetch applicable host records from HBI, with the exception of orgId. Since the query (used by the nightly) is made based on the opted-in org list, we need to also filter any incoming Swatch Event messages so that Events are not persisted for orgs that will not be tallied. We do not currently want to open upnightly tally for every org that sends data to HBI. NOTE: The opt-in check added to the EventController does not add any overhead since we continue to do at most one check per event.
Periodically tests would fail because of a conflict with the management port for swatch-metrics-hbi. Disabling management for this service during testing
Remove swatch-core dependency from swatch-metrics-hbi
…mpileQuarkusGeneratedSourcesJava and testCodeCoverageReport
HBI event ingestion will need these new properties when creating Host records during nightly tally Moved the HypervisorGuestRepository out of MeasurementNormalizer.
The HypervisorRelationshipService is responsible for tracking the relationships between incoming hypervior hosts and their guests. Currently creates required DB tables and provides basic funtionality. Contains some stubbed service methods and tests that will be updated/implemented in follow-on commits.
When processing an incoming HBI event, update the relationships for the host. If we are processing a hypervisor, re-process the event data for any unmapped guest and send an event for each guest with updated measurements.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira issue: SWATCH-XXXX
Description
Testing
IQE Test MR:
Setup
Steps
Verification