Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CVSS v4.0 rounding #61

Merged
merged 1 commit into from
Sep 7, 2024
Merged

Fix CVSS v4.0 rounding #61

merged 1 commit into from
Sep 7, 2024

Conversation

skontar
Copy link
Collaborator

@skontar skontar commented Sep 7, 2024

Fixes rounding issues in v4.0 by changing rounding algorithm to:

  1. Correctly handle float limitations
  2. Perform rounding with "half round up" strategy as expected

All tests pass for both this Python implementation and Javascript implementation.

@skontar skontar force-pushed the skontar_fix_rounding branch from b2554fc to 52bed32 Compare September 7, 2024 13:01
@skontar
Copy link
Collaborator Author

skontar commented Sep 7, 2024

Fixes #59 and #60.

@skontar skontar merged commit 89801dc into master Sep 7, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant