Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replicate CVSS4.from_rh_vector #68

Merged

Conversation

rhyw
Copy link
Contributor

@rhyw rhyw commented Feb 6, 2025

Closes #67

@rhyw
Copy link
Contributor Author

rhyw commented Feb 6, 2025

The from_rh_vector is still useful for handling exceptions.

@rhyw
Copy link
Contributor Author

rhyw commented Feb 7, 2025

@skontar PTAL

@skontar
Copy link
Collaborator

skontar commented Feb 7, 2025

@mprpic it seems that CI is failing. Would you mind having a look?

@rhyw rhyw force-pushed the replicate-cvss4-from-rh-vector branch from c593410 to b2c99dd Compare February 11, 2025 10:20
@rhyw
Copy link
Contributor Author

rhyw commented Feb 11, 2025

py2.7 tox complains about f-strings, addressed in latest code.

@rhyw rhyw force-pushed the replicate-cvss4-from-rh-vector branch from b2c99dd to b116631 Compare February 11, 2025 11:45
@rhyw rhyw force-pushed the replicate-cvss4-from-rh-vector branch from b116631 to bf23481 Compare February 11, 2025 14:05
@rhyw rhyw requested a review from skontar February 11, 2025 14:08
@skontar skontar requested a review from jsvob February 11, 2025 14:13
@skontar
Copy link
Collaborator

skontar commented Feb 11, 2025

@jsvob please also review and also make a release afterwards. Thanks!

Copy link
Collaborator

@jsvob jsvob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you for your contribution!

@jsvob jsvob merged commit 99d0193 into RedHatProductSecurity:master Feb 11, 2025
11 checks passed
@rhyw rhyw deleted the replicate-cvss4-from-rh-vector branch February 12, 2025 02:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Do we have a CVSS3.from_rh_vector equivalent for CVSS4?
3 participants