Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Osim taskman integration #364

Merged
merged 5 commits into from
Dec 7, 2023
Merged

Osim taskman integration #364

merged 5 commits into from
Dec 7, 2023

Conversation

costaconrado
Copy link
Contributor

@costaconrado costaconrado commented Oct 24, 2023

This PR introduces a query building based interaction with Jira.

This new query generator reduces the number of endpoints exposed by Taskman simplifying the interactions with the module.
This PR also disables tests from old service that will bi completely disabled as a following task (OSIDB-1490).
This PR also masks Jira Status/Resolution from queries, enabling us to freely map any status from Jira and exposing OSIM status for users that makes sense with new IR workflow.

Closes OSIDB-1321.

@costaconrado costaconrado force-pushed the osim-taskman-integration branch 5 times, most recently from 96ad07d to ed11a16 Compare October 24, 2023 01:08
@costaconrado costaconrado requested a review from a team October 24, 2023 11:50
Copy link
Contributor

@osoukup osoukup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am opened to discussion but I do not think this is the correct approach. I think that tasks should be more abstracted and in the background of the flaw management. Not directly operated through the task API.

apps/taskman/jira_serializer.py Outdated Show resolved Hide resolved
apps/taskman/jira_serializer.py Outdated Show resolved Hide resolved
@costaconrado costaconrado force-pushed the osim-taskman-integration branch 2 times, most recently from d7778ea to da335be Compare October 24, 2023 22:32
@costaconrado costaconrado force-pushed the osim-taskman-integration branch 5 times, most recently from 0121183 to 0dfc971 Compare November 27, 2023 20:56
@costaconrado costaconrado requested a review from osoukup November 28, 2023 22:57
@costaconrado costaconrado force-pushed the osim-taskman-integration branch from b7aaf9d to 523799f Compare November 29, 2023 13:42
Copy link
Contributor

@osoukup osoukup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

docs/CHANGELOG.md Outdated Show resolved Hide resolved
@costaconrado costaconrado force-pushed the osim-taskman-integration branch 5 times, most recently from fda8080 to bd21d61 Compare December 5, 2023 21:04
Signed-off-by: Conrado Costa <[email protected]>
@costaconrado costaconrado force-pushed the osim-taskman-integration branch 2 times, most recently from baec2d3 to 87e54f5 Compare December 7, 2023 15:18
@costaconrado costaconrado force-pushed the osim-taskman-integration branch from 87e54f5 to 042f84d Compare December 7, 2023 15:42
@costaconrado costaconrado force-pushed the osim-taskman-integration branch from 042f84d to 827547d Compare December 7, 2023 15:48
@costaconrado costaconrado requested a review from osoukup December 7, 2023 15:48
Copy link
Contributor

@osoukup osoukup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@costaconrado costaconrado added this pull request to the merge queue Dec 7, 2023
Merged via the queue into master with commit 1869185 Dec 7, 2023
10 of 11 checks passed
@costaconrado costaconrado deleted the osim-taskman-integration branch December 7, 2023 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants