Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update version to 4.3.1 #731

Merged
merged 1 commit into from
Sep 11, 2024
Merged

Update version to 4.3.1 #731

merged 1 commit into from
Sep 11, 2024

Conversation

jsvob
Copy link
Contributor

@jsvob jsvob commented Sep 11, 2024

see the changelog

@jsvob jsvob requested a review from a team September 11, 2024 10:48
Copy link
Contributor

@osoukup osoukup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would await that the change with the new API endpoints extends the API but there is nothing in the diff and regenerating the schema makes no changes. LGTM

@JakubFrejlach
Copy link
Contributor

I would await that the change with the new API endpoints extends the API but there is nothing in the diff and regenerating the schema makes no changes. LGTM

That is because those API endpoint changes were purposely hidden from the API schema:
fbae64e#diff-4a51610181bd496db117d73122150acb06a494798165c70ce3c1b15252430ceaR454
fbae64e#diff-4a51610181bd496db117d73122150acb06a494798165c70ce3c1b15252430ceaR444

Not sure about the actual reason, I guess @MrMarble knows more.

@MrMarble
Copy link
Member

I would await that the change with the new API endpoints extends the API but there is nothing in the diff and regenerating the schema makes no changes. LGTM

That is because those API endpoint changes were purposely hidden from the API schema: fbae64e#diff-4a51610181bd496db117d73122150acb06a494798165c70ce3c1b15252430ceaR454 fbae64e#diff-4a51610181bd496db117d73122150acb06a494798165c70ce3c1b15252430ceaR444

Not sure about the actual reason, I guess @MrMarble knows more.

Those endpoints are intended to work only with djangoql comletion library https://github.com/ivelum/djangoql-completion and not directly by the users, that's why I decided to keep them private, like we do with jira_stage_forwarder

osidb/osidb/urls.py

Lines 102 to 108 in 963cbc4

if get_env() != "prod":
urlpatterns.append(
path(
f"api/{OSIDB_API_VERSION}/jira_stage_forwarder",
JiraStageForwarderView.as_view(),
)
)
no other reason a part from that.
If you think makes sense to document them on the API feel free to include them

@JakubFrejlach
Copy link
Contributor

I would await that the change with the new API endpoints extends the API but there is nothing in the diff and regenerating the schema makes no changes. LGTM

That is because those API endpoint changes were purposely hidden from the API schema: fbae64e#diff-4a51610181bd496db117d73122150acb06a494798165c70ce3c1b15252430ceaR454 fbae64e#diff-4a51610181bd496db117d73122150acb06a494798165c70ce3c1b15252430ceaR444
Not sure about the actual reason, I guess @MrMarble knows more.

Those endpoints are intended to work only with djangoql comletion library https://github.com/ivelum/djangoql-completion and not directly by the users, that's why I decided to keep them private, like we do with jira_stage_forwarder

osidb/osidb/urls.py

Lines 102 to 108 in 963cbc4

if get_env() != "prod":
urlpatterns.append(
path(
f"api/{OSIDB_API_VERSION}/jira_stage_forwarder",
JiraStageForwarderView.as_view(),
)
)

no other reason a part from that.
If you think makes sense to document them on the API feel free to include them

I see, I guess we don't need to show them to people in this case. Thanks for the explanation.

@jsvob jsvob merged commit d8389b4 into release-4.3.1 Sep 11, 2024
12 checks passed
@jsvob jsvob deleted the release-4.3.1-prep branch September 11, 2024 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants