Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

disable external user ID queries #855

Merged
merged 1 commit into from
Dec 19, 2024
Merged

disable external user ID queries #855

merged 1 commit into from
Dec 19, 2024

Conversation

osoukup
Copy link
Contributor

@osoukup osoukup commented Dec 9, 2024

Closes OSIDB-2925

@osoukup osoukup requested a review from a team December 9, 2024 14:47
@osoukup osoukup self-assigned this Dec 9, 2024
@osoukup osoukup added the technical For PRs that introduce changes not worthy of a CHANGELOG entry label Dec 10, 2024
JakubFrejlach
JakubFrejlach reviewed Dec 10, 2024
View reviewed changes
Copy link
Contributor

@JakubFrejlach JakubFrejlach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before approval I would probably like to discuss briefly what is our aim for profiles. Changes don't seem to be saving much of a traffic, at least from my understanding of the logic.

@osoukup osoukup added this pull request to the merge queue Dec 19, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 19, 2024
@osoukup osoukup added this pull request to the merge queue Dec 19, 2024
Merged via the queue into master with commit 5caca09 Dec 19, 2024
13 checks passed
@osoukup osoukup deleted the disable-external-user-queries branch December 19, 2024 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JakubFrejlach JakubFrejlach JakubFrejlach approved these changes

Assignees

@osoukup osoukup

Labels
technical For PRs that introduce changes not worthy of a CHANGELOG entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@osoukup @JakubFrejlach