Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Amend logic for user to pghistory context mapping #912

Merged
merged 2 commits into from
Mar 3, 2025
Merged

Amend logic for user to pghistory context mapping #912

merged 2 commits into from
Mar 3, 2025
+48 −1

Conversation

superbuggy
Copy link
Contributor

@superbuggy superbuggy commented Feb 17, 2025 •
edited
Loading

  • Test on staging environment

Closes OSIDB-3464

@superbuggy superbuggy requested a review from a team February 17, 2025 19:55
@superbuggy superbuggy self-assigned this Feb 17, 2025
@superbuggy superbuggy force-pushed the feature/OSIDB-3464-user-mapping-in-history branch from 6063ee7 to ea6ecb5 Compare February 17, 2025 20:17
osoukup
osoukup approved these changes Feb 18, 2025
View reviewed changes
Copy link
Contributor

@osoukup osoukup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I see that it required really small adjustion

@jsvob
Copy link
Contributor

jsvob commented Feb 18, 2025

Wow, that's wild. Nice!

@superbuggy
Copy link
Contributor Author

Wow, that's wild. Nice!

Yeah the middleware was quite clever about using python's metaprogramming API to 'hook' into updates to the user. It's a little hacky to me, but it seems adequate

@superbuggy
Copy link
Contributor Author

LGTM. I see that it required really small adjustion

It did, I was glad you shared that intuition with me earlier because it reinforced my own, and I avoided some rabbit holes in favor of this solution.

@superbuggy superbuggy requested a review from a team February 18, 2025 13:54
@superbuggy superbuggy added this pull request to the merge queue Mar 3, 2025
@superbuggy superbuggy removed this pull request from the merge queue due to a manual request Mar 3, 2025
@superbuggy
Reapply "Map user name or email to pghistory context..." (6139e55) (#910
eebd72c 
)

This reverts commit 7c8810d, reversing
changes made to fa64860.
@superbuggy
Fix user mapping logic in middleware
4b42ea2 
Remove blank line

Update changelog
@superbuggy superbuggy force-pushed the feature/OSIDB-3464-user-mapping-in-history branch from ea6ecb5 to 4b42ea2 Compare March 3, 2025 14:45
@superbuggy superbuggy enabled auto-merge March 3, 2025 14:46
@superbuggy superbuggy added this pull request to the merge queue Mar 3, 2025
Merged via the queue into master with commit 4e5fb96 Mar 3, 2025
11 checks passed
@superbuggy superbuggy deleted the feature/OSIDB-3464-user-mapping-in-history branch March 3, 2025 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jobselko jobselko jobselko approved these changes

@osoukup osoukup osoukup approved these changes

Assignees

@superbuggy superbuggy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@superbuggy @jsvob @jobselko @osoukup