updated entrypoint to use python3.12 #310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ccronca
approved these changes
Feb 25, 2025
There was a problem hiding this comment.
lgtm
Just one note, in Python 3.12, the standard library's ensurepip and venv modules no longer install setuptools alongside pip. Currently, it works because of the python3 -m ensurepip --upgrade line in the Containerfile. However, if we change the default interpreter in the Containerfile, we need to ensure that setuptools is explicitly installed when dependencies are prefetched. Otherwise, the installation of py-nessus-pro may fail due to the absence of this package.
jeremychoi
merged commit 3118e83
into
RedHatProductSecurity:development
5 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated ENTRYPOINT to use python3.12.
Alternatively we could link python3 to python3.12, but for now keeping both python versions may be ok. This will be changed later as necessary.