e2e: Replace ad-hoc task with Konflux-provided dependency fetching #313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaced the custom task for retrieving the prefetched dependency artifact in the E2E task with the one provided by Konflux.
|
Pending konflux-ci/tekton-integration-catalog#117 to be merged |
sfowl
approved these changes
Feb 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced the custom task for retrieving the prefetched dependency artifact in the E2E task with the one provided by Konflux.
Although the
test-metadatastep could also be replaced, doing so would require additional work. The new task formats results as a JSON object (job-spec), which would require additional tooling (jq) in the affected tasks to parse this result. So, I have left thetest-metadatastep unchanged.