feat: 295 monorepo directory structure design proposal #389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l values. improves config error handling.
hbraswelrh
reviewed
Nov 20, 2024
hbraswelrh
reviewed
Nov 20, 2024
hbraswelrh
reviewed
Nov 20, 2024
qduanmu
force-pushed
the
295-monorepo-directory-structure-design-proposal
branch
from
23ac47d to
0237e3b
Compare
qduanmu
force-pushed
the
295-monorepo-directory-structure-design-proposal
branch
from
0237e3b to
823e5bc
Compare
…thub.com:RedHatProductSecurity/trestle-bot into 295-monorepo-directory-structure-design-proposal
…thub.com:RedHatProductSecurity/trestle-bot into 295-monorepo-directory-structure-design-proposal
jpower432
reviewed
Nov 21, 2024
jpower432
reviewed
Nov 21, 2024
qduanmu
reviewed
Nov 22, 2024
…thub.com:RedHatProductSecurity/trestle-bot into 295-monorepo-directory-structure-design-proposal
gvauter
commented
Nov 26, 2024
Co-authored-by: Jennifer Power <[email protected]>
Co-authored-by: Jennifer Power <[email protected]>
gvauter
commented
Dec 3, 2024
| @click.option( | ||
| "--ssp-name", | ||
| prompt="Enter name of SSP to create", | ||
| help="Name of SSP to create.", |
There was a problem hiding this comment.
Yes, required=True should be set here. I'm not sure on the prompt. Today we do have a Github action for the create-cd command, so prompting would not work. It might be safest to let it error out and exit.
trestlebot/cli/commands/create.py
Outdated
| ) | ||
| @click.option( | ||
| "--compdefs", | ||
| required=False, |
There was a problem hiding this comment.
For consistency I would vote we stick with the command sep list for now. I do believe is required for the create ssp command.
…thub.com:RedHatProductSecurity/trestle-bot into 295-monorepo-directory-structure-design-proposal
gvauter
commented
Dec 4, 2024
qduanmu
force-pushed
the
295-monorepo-directory-structure-design-proposal
branch
from
8cd7085 to
1669ea8
Compare
…thub.com:RedHatProductSecurity/trestle-bot into 295-monorepo-directory-structure-design-proposal
4 tasks
qduanmu
previously approved these changes
Dec 13, 2024
qduanmu
dismissed
their stale review
I noted there are some missing options in create command.
qduanmu
reviewed
Dec 13, 2024
| @create_cmd.command(name="compdef", help="Component definition authoring subcommand.") | ||
| @click.pass_context | ||
| @common_create_options | ||
| @common_options |
There was a problem hiding this comment.
@hbraswelrh , @git_options should be added here.
| tmp_init_dir, | ||
| ], | ||
| ) | ||
| assert result.exit_code == 2 |
There was a problem hiding this comment.
The expected exit_code is 2? Is there any context I missed?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR contains the initial code for a Click based CLI for trestle-bot as described in ADR-001. This Click based CLI will replace the existing
entrypointsmodules. This PR only contains the code for the CLI, it does not break any existing commands/actions. Subsequent PRs will make the necessary changes to swap the current entrypoints with these new CLI commands.Fixes # #295
Type of change
How has this been tested?
Unit tests have been added in
tests/clifor all new CLI commands/modules.Checklist