Add module upgrade instructions to RS upgrade steps #2553
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Nermina Miller <[email protected]>
LiorKogan
reviewed
May 12, 2023
| - `module_args keep_args` to use the existing module arguments. | ||
|
|
||
| For module upgrade examples, see [Upgrade modules]({{<relref "/modules/install/upgrade-module#examples">}}). | ||
|
|
||
| 1. Check the Redis database compatibility version for the database to confirm the upgrade. |
There was a problem hiding this comment.
I find the term "Redis database compatibility version" and the sentence "the Redis version displays the Redis database compatibility version." a bit confusing.
What exactly should be compatible with what? How do you verify compatibility? minimal version? exact version?
Maybe add a sample output and explain how to check this.
There was a problem hiding this comment.
@adisht @maayanagranat, in regard to Lior's comment about "Redis database compatibility version" in the upgrade database instructions, should we change this to something like "Redis database version" instead?
cmilesb
approved these changes
May 12, 2023
|
@rrelledge is this PR still valid? |
kaitlynmichael
requested changes
Dec 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For DOC-1411.
Staged previews:
rladmin upgradecommand