Fix #1134 - Bug in Reference LAPACKE’s cunmlq and zunmlq for row-major layout and side right #1135
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mlq for row-major layout and side right Bug reported by @neil-lindquist. Thanks Neil! On line 93 of both lapacke_cunmlq_work.c and lapacke_zunmlq_work.c, m is passed to LAPACKE_zge_trans as the 2nd dimension. However, the 2nd dimension should be r to handle side right correctly. All the other versions of {or,un}m{qr,lq} seem to be correct. Also line 52 of lapacke_cunmlq.c and lapacke_zunmlq.c have the same issue: m is used for the column dimension instead of r. (Those files also do not currently compute r). The real valued cases have the correct behavior.
amontoison
approved these changes
Jun 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug reported by @neil-lindquist. Thanks Neil!
On line 93 of both lapacke_cunmlq_work.c and lapacke_zunmlq_work.c, m is passed to LAPACKE_zge_trans as the 2nd dimension. However, the 2nd dimension should be r to handle side right correctly. All the other versions of {or,un}m{qr,lq} seem to be correct.
Also line 52 of lapacke_cunmlq.c and lapacke_zunmlq.c have the same issue: m is used for the column dimension instead of r. (Those files also do not currently compute r). The real valued cases have the correct behavior.