Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests for SPCS Azure #46

Merged
merged 10 commits into from
Nov 26, 2024
Merged

Tests for SPCS Azure #46

merged 10 commits into from
Nov 26, 2024

Conversation

alexrenz
Copy link
Member

@alexrenz alexrenz commented Nov 19, 2024

Add a few tests for SPCS Azure, as introduced by object_store_ffi#28

@alexrenz alexrenz changed the title Support SPCS Azure Tests for SPCS Azure Nov 19, 2024
@alexrenz alexrenz marked this pull request as ready for review November 19, 2024 18:16
Copy link
Member

@andrebsguedes andrebsguedes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, some small comments.

src/mock_server.jl Show resolved Hide resolved
src/mock_server.jl Outdated Show resolved Hide resolved
test/snowflake_stage_exception_tests.jl Show resolved Hide resolved
Copy link
Member

@andrebsguedes andrebsguedes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Added one more comment on the url parsing thing but you can take it or leave it.

@alexrenz alexrenz merged commit aa07471 into main Nov 26, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants