Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added missing scanline.glsl shader to the shaders directory #10

Closed
wants to merge 10 commits into from
Closed

Added missing scanline.glsl shader to the shaders directory #10

wants to merge 10 commits into from

Conversation

snemes
Copy link

@snemes snemes commented Oct 11, 2017

Two minor changes:

  1. The scanline.glsl shader was missing, but is referenced by the snes_scanline.glslp preset.
  2. Removed the unnecessary 'executable' attribute from the files.

@snemes
Copy link
Author

snemes commented Oct 28, 2017

Also fixed an incorrect shader path in snes.glslp

@joolswills
Copy link
Member

Your PR includes permission changes on the files. They are possibly correct to be changed to 644, but that should be done in a separate PR please.

@snemes snemes closed this Oct 28, 2017
@joolswills
Copy link
Member

Note - You don't need to close the PR - you can force push back to the branch after correcting your local branch.

@snemes
Copy link
Author

snemes commented Oct 28, 2017

I just got lost in the maze of git commit squashes, and it seemed easier to just redo things, sorry. :)

@snemes
Copy link
Author

snemes commented Oct 28, 2017

Will create 2 new pull requests.

@snemes
Copy link
Author

snemes commented Oct 28, 2017

Created #11 and #12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants