[Paywalls V2] Fix border being hidden by next sibling component #4523
+14
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JayShortway
reviewed
Nov 27, 2024
Comment on lines
+182
to
+188
| #if PAYWALL_COMPONENTS | ||
| .onAppear { | ||
| if let errorInfo = paywall.offering.paywallComponentsData?.errorInfo { | ||
| print("Paywall V2 Error:", errorInfo.debugDescription) | ||
| } | ||
| } | ||
| #endif |
There was a problem hiding this comment.
Just checking: is this intended?
There was a problem hiding this comment.
Not sure if intended, but definitely useful, I've added something similar locally in the past to debug paywall errors so I'd keep it.
There was a problem hiding this comment.
Yea I agree! Maybe we should use our logger though, instead of a print statement?
MarkVillacampa
approved these changes
Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
There was an issue where a sibiling component would overlap the border and make it look like border didn't exist
Description
Just needed to subtract 1 from the max y
Screenshots