Fixed #51.

CHANGELOG.md

@@ -1,5 +1,10 @@
 # Changelog
 
+#### 2.0.1
+###### _May 23, 2020_
+
+- Fixed bug where setting *sound* to *false* had no effect ([#51](/../../issues/51)).
+
 #### 2.0.0
 ###### _October 15, 2019_
 

package.json

@@ -1,6 +1,6 @@
 {
   "name": "webpack-build-notifier",
-  "version": "2.0.0",
+  "version": "2.0.1",
   "description": "A Webpack plugin that generates OS notifications for build steps using node-notifier.",
   "main": "dist/index.js",
   "types": "dist/index.d.ts",
@@ -50,7 +50,7 @@
     "ts-jest": "^24.1.0",
     "tslint": "^5.20.0",
     "tslint-config-airbnb": "^5.11.2",
-    "typescript": "^3.6.4",
+    "typescript": "^3.9.3",
     "webpack": "^4.41.2"
   }
-}
+}

src/index.ts

@@ -24,10 +24,10 @@ export default class WebpackBuildNotifierPlugin {
   private title: string = 'Webpack Build';
   private logo?: string;
   private sound: string = 'Submarine';
-  private successSound: string = this.sound;
-  private warningSound: string = this.sound;
-  private failureSound: string = this.sound;
-  private compilationSound: string = this.sound;
+  private successSound: string;
+  private warningSound: string;
+  private failureSound: string;
+  private compilationSound: string;
   private suppressSuccess: boolean | 'always' | 'initial' = false;
   private suppressWarning: boolean = false;
   private suppressCompileStart: boolean = true;
@@ -47,6 +47,13 @@ export default class WebpackBuildNotifierPlugin {
   constructor(cfg?: Config) {
     Object.assign(this, cfg);
 
+    if (this.sound) {
+      this.successSound = this.successSound ?? this.sound;
+      this.warningSound = this.warningSound ?? this.sound;
+      this.failureSound = this.failureSound ?? this.sound;
+      this.compilationSound = this.compilationSound ?? this.sound;
+    }
+
     this.registerSnoreToast();
 
     notifier.on('click', this.onClick);

tests/test.spec.ts

@@ -116,6 +116,23 @@ describe('Test Webpack build', () => {
         });
       });
 
+      it('Should show a success notification with no sound', (done) => {
+        const onComplete = jest.fn();
+        expect.assertions(2);
+        webpack(getWebpackConfig({ onComplete, sound: false }), (err, stats) => {
+          expect(notifier.notify).toHaveBeenCalledWith({
+            appName: platformName === 'Windows' ? 'Snore.DesktopToasts' : undefined,
+            contentImage: undefined,
+            icon: require.resolve('../src/icons/success.png'),
+            message: 'Build successful!',
+            title: 'Build Notification Test - Success',
+            wait: false,
+          });
+          expect(onComplete).toHaveBeenCalledWith(expect.any(Object), CompilationStatus.SUCCESS);
+          done();
+        });
+      });
+
       it('Should show a success notification with duration', (done) => {
         expect.assertions(1);
         webpack(getWebpackConfig({ showDuration: true }), (err, stats) => {