Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sounds play when sound is false #51

Closed
bwoolnough opened this issue Dec 19, 2019 · 3 comments
Closed

Sounds play when sound is false #51

bwoolnough opened this issue Dec 19, 2019 · 3 comments
Assignees
@RoccoC
Labels
bug

Comments

@bwoolnough
Copy link

Setting sound to false doesn't prevent sounds from playing. It only works if I set the specific sound options (successSound etc) to false.

I am using macOS 10.15.2 and webpack-build-notifier 2.0.0.
@jimblue
Copy link

jimblue commented May 24, 2020

I can reproduce that bug on latest release too.
@RoccoC can you confirm that please ?
This bug is really annoying for development !
Tks man :)

@RoccoC RoccoC self-assigned this May 24, 2020
RoccoC added a commit that referenced this issue May 24, 2020
@RoccoC
Fixed #51
2105c0b
@RoccoC RoccoC closed this as completed in c59f530 May 24, 2020
RoccoC added a commit that referenced this issue May 24, 2020
@RoccoC
Revert "Fixed #51."
c10e84a 
This reverts commit c59f530.
RoccoC added a commit that referenced this issue May 24, 2020
@RoccoC
Fixed #51.
ba2e03a
@RoccoC
Copy link
Owner

RoccoC commented May 24, 2020

Whoops, somehow this bug fell off my radar. This one is now fixed in 2.0.1.

@jimblue
Copy link

jimblue commented May 24, 2020

No worries @RoccoC and thank you so much for the quick fix 💯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RoccoC RoccoC

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@RoccoC @jimblue @bwoolnough