Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect messageFormatter type #72

Merged
merged 1 commit into from
Apr 30, 2021
Merged

Conversation

astorije
Copy link
Contributor

Fixes #68

It looks like I messed up a rebase or something. Sorry!

(It would be nice if the types were not defined twice as I've hit this a couple times in my PRs. I can take a stab at consolidating them from the Config object if you're interested)

It looks like I messed up a rebase or something. Sorry!
@coveralls
Copy link

Pull Request Test Coverage Report for Build 155

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 93.636%

Totals Coverage Status
Change from base Build 151: 0.0%
Covered Lines: 130
Relevant Lines: 134

💛 - Coveralls

@RoccoC
Copy link
Owner

RoccoC commented Apr 30, 2021

Whoops! I missed it, too.

Yeah, would be better if that type wasn't defined twice. I'll merge your PR and will consolidate the types.

@RoccoC RoccoC merged commit 04e773b into RoccoC:master Apr 30, 2021
@RoccoC
Copy link
Owner

RoccoC commented May 1, 2021

Done: ba29e0d

Although it would probably have been cleaner to just collapse all of the individual class properties into one config object, e.g.:

before:

export default class WebpackBuildNotifierPlugin {
  // config options
  private title: string = 'Webpack Build';
  private logo?: string;
  private sound: string = 'Submarine';
  private successSound: string;
  private warningSound: string;
  ...

after:

export default class WebpackBuildNotifierPlugin {
  private config: Config;
...

Maybe an improvement for another time. :)

@RoccoC
Copy link
Owner

RoccoC commented May 1, 2021

Thanks for the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants