Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: inner attachment empty when quoting multiple times #35369

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

abhinavkrin
Copy link
Member

@abhinavkrin abhinavkrin commented Feb 28, 2025

Proposed changes (including videos or screenshots)

Fixes an issue where quoting an attachment (image, video, file, audio) multiple times resulted in the inner attachment being empty. The description and preview was lost in the inner message.
before
Screenshot 2025-03-01 at 2 47 34 AM

after
Screenshot 2025-03-01 at 2 45 50 AM

Issue(s)

Steps to test or reproduce

Further comments

CORE-37

@abhinavkrin abhinavkrin requested review from a team as code owners February 28, 2025 21:19
Copy link
Contributor

dionisio-bot bot commented Feb 28, 2025

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Feb 28, 2025

🦋 Changeset detected

Latest commit: 13776e9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 35 packages
Name Type
@rocket.chat/core-typings Patch
@rocket.chat/meteor Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/api-client Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/ddp-client Patch
@rocket.chat/freeswitch Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/gazzodown Patch
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/rest-typings Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/network-broker Patch
@rocket.chat/models Patch
@rocket.chat/ui-avatar Patch
@rocket.chat/ui-client Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/ui-voip Patch
@rocket.chat/web-ui-registration Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@abhinavkrin abhinavkrin added this to the 7.5.0 milestone Feb 28, 2025
@abhinavkrin abhinavkrin force-pushed the fix/quoting-attachment-inner-empty branch from 017207b to 13776e9 Compare March 1, 2025 06:17
Copy link

codecov bot commented Mar 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.43%. Comparing base (4a123e3) to head (13776e9).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #35369   +/-   ##
========================================
  Coverage    59.42%   59.43%           
========================================
  Files         2829     2829           
  Lines        68334    68339    +5     
  Branches     15133    15135    +2     
========================================
+ Hits         40610    40615    +5     
  Misses       25066    25066           
  Partials      2658     2658           
Flag Coverage Δ
unit 75.50% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant