-
Notifications
You must be signed in to change notification settings - Fork 11.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: grandfather apps installed before 7.0.0 while handling license downgrades #35374
base: develop
Are you sure you want to change the base?
Conversation
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
🦋 Changeset detectedLatest commit: 13cfa08 The changes in this PR will be included in the next version bump. This PR includes changesets to release 35 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #35374 +/- ##
========================================
Coverage 59.42% 59.42%
========================================
Files 2829 2829
Lines 68334 68334
Branches 15133 15133
========================================
Hits 40610 40610
Misses 25066 25066
Partials 2658 2658
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
5f986ed
to
d84a316
Compare
Proposed changes (including videos or screenshots)
Previously, when a workspace downgraded from a trial or paid license to the community edition, all installed apps (both marketplace and private apps) remained enabled, regardless of the workspace’s new limitations. This led to workspaces retaining premium features beyond what was intended.
Marketplace Apps:
Private Apps:
Issue(s)
Steps to test or reproduce
Marketplace Apps
Private Apps
Grandfathered Private Apps
rocketchat_statistics
collection.version
field to a pre-7 version (e.g., 6.9.0).installedDate
to a date before the upgrade to version 7.rocketchat_apps
collection):createdDate
field to a date that aligns with the pre-7 installation date.Further comments
It's a bit tricky to enforce the grandfathering condition reliably. After discussing with the team, we identified a potential approach: checking app statistics. If any recorded statistics indicate usage from a pre-7 version, we can infer that the workspace previously ran that version, allowing us to determine eligibility for grandfathering.