Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Dropdown not closing when clicking outside and obstructing 'Create' button in Direct Message modal (#35375) #35376

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

schourasia750
Copy link

Closes #35375
Type: Bug

Description

This pull request fixes the issue where the dropdown in the 'Create Direct Message' modal does not close when clicking outside, and when there are many suggested users, it obstructs the 'Create' button.

Changes Made

  • Implemented click-outside detection: The dropdown now closes when the user clicks outside of it.
  • Added drop-up functionality: The dropdown opens upwards when there is insufficient space below, preventing it from covering the 'Create' button.
  • Ensured full-width input box: The user input field now maintains full width for better usability.

Testing

  • Manually tested the dropdown behavior in the 'Create Direct Message' modal.
  • Confirmed that clicking outside the dropdown closes it.
  • Verified that the dropdown adjusts its position based on available space (drop-up functionality).
  • Ensured that selecting and removing users works as expected.
  • Checked that the input box stretches to fill the available space.

Before

Watch the video preview: Google Drive Video

After

Watch the video preview: Google Drive Video

@schourasia750 schourasia750 requested a review from a team as a code owner March 1, 2025 05:07
Copy link
Contributor

dionisio-bot bot commented Mar 1, 2025

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label
  • This PR is missing the required milestone or project

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Mar 1, 2025

⚠️ No Changeset found

Latest commit: 843d761

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@CLAassistant
Copy link

CLAassistant commented Mar 1, 2025

CLA assistant check
All committers have signed the CLA.

@schourasia750 schourasia750 changed the title [FIX] Dropdown not closing when clicking outside and obstructing 'Create' button in Direct Message modal fix: Dropdown not closing when clicking outside and obstructing 'Create' button in Direct Message modal (#35375) Mar 1, 2025
@schourasia750
Copy link
Author

@ggazzo Could you please assign the appropriate labels and milestone to this PR? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Create Direct Message" modal does not close when clicking outside and obstructs "Create" button
3 participants