Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve spherize node #667

Merged
merged 2 commits into from
Apr 30, 2024
Merged

Improve spherize node #667

merged 2 commits into from
Apr 30, 2024

Conversation

williamchange
Copy link
Contributor

sph_demo

Some improvements for the Spherize node, mainly:

  • Add center x/y control widgets
  • Don't clamp input image values
  • Prevent taking square root with negative values(this now takes the absolute before sqrt), which caused some visual issue on Mac OS - I previously made the node on 12.6.x which works fine but it worked differently in 14.3

@williamchange
improve spherize node
c75d5b6 
- add center x/y control widgets
- don't clamp input image values
- prevent taking square root with negative values(abs before sqrt)
@williamchange
Merge branch 'RodZill4:master' into improve-spherize
33f4c50
@RodZill4 RodZill4 added this to the 1.4 milestone Feb 27, 2024
@williamchange
Copy link
Contributor Author

Finalized, no further changes planned.

@RodZill4 RodZill4 merged commit a85d9c8 into RodZill4:master Apr 30, 2024
2 checks passed
@williamchange williamchange deleted the improve-spherize branch May 1, 2024 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.4
Development

Successfully merging this pull request may close these issues.
2 participants
@williamchange @RodZill4