Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the debugger is enabled, the game runs at a million frames per second, making it impossible to actually play while waiting for breakpoints or doing any real work.
This PR is an attempt to fix the emulation speed by allowing the interpreter to synchronize with the host's refresh rate in a way similar to the normal emulation control flow. I had to add extra state to capture whether the debugger wants to pause emulation, rather than relying on the
EmulatorState
control flow.I also adjusted the debugger CPU frequency to slow it down a bit more. It was still running way too fast (at least on my laptop) even with vsync.
Not sure if you want this patch or if you have a better solution. But it unblocked me. I was able to use the debugger to find what I needed after all of these patches.