Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Destructible tiles #60

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

leo-in-the-house
Copy link
Contributor

-Add the ability for tiles to be instantly destroyed with Moves of certain types and power. Effects can be spawned when the tile is destroyed this way.
-Add an "Object" category for tiles. Objects cannot be passed through but can be attacked through, and items inside of an object are hidden until the object is destroyed.

@audinowho
Copy link
Contributor

Several uncertainties about this PR, those being the power needed to destroy and the effective elements. Those seem somewhat hardcoded to a particular purpose and are potentially better off implemented as a TileState. However, I will need to see more about how they're being used. Can you link the code that uss these two members?

Aside from that, it would be ideal to separate some of these changes into their own PRs:

-Create a PR for the feature of hiding items behind objects.
-Create a PR for the changes that involve the new TileAttackBlocked methods.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants