Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamic modal names #94

Merged
merged 9 commits into from
Oct 26, 2024
Merged

Dynamic modal names #94

merged 9 commits into from
Oct 26, 2024

Conversation

Royal-lobster
Copy link
Owner

@Royal-lobster Royal-lobster commented Oct 25, 2024

Closes #93

Changes

  • Dynamic modal names from /modals
  • Deprecates usage of ollama modals directly, we can now use them via openai compatible endpoint

Summary by CodeRabbit

Release Notes

  • New Features

    • Introduced dynamic modal names sourced from the /modals directory.
    • Transitioned to an OpenAI-compatible endpoint for modal access, streamlining integration.
  • Improvements

    • Enhanced the ChatSettings and Auth components for better state management and user interaction.
    • Simplified chat model handling across various components, improving overall user experience.
  • Bug Fixes

    • Resolved issues related to model selection and API key submission.
  • Chores

    • Removed deprecated code and streamlined settings management.

Copy link

stackblitz bot commented Oct 25, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

changeset-bot bot commented Oct 25, 2024

🦋 Changeset detected

Latest commit: 8df3cc0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
syncia Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

coderabbitai bot commented Oct 25, 2024

Caution

Review failed

The pull request is closed.

Walkthrough

The changes introduce a new patch for "syncia" that allows dynamic modal names to be sourced from the /modals directory, replacing the previous use of the AvailableModels enum. The integration with OpenAI's endpoint is streamlined, enhancing the handling of chat models across various components. Modifications were made to several components, including ChatSettings, Auth, and ChangeChatModel, to reflect this new structure, improving state management and simplifying user interactions.

Changes

File Path Change Summary
.changeset/eight-melons-cheer.md New patch added for "syncia" to support dynamic modal names from /modals directory.
src/components/Settings/Sections/ChatSettings.tsx Adjusted imports, updated API key handling, removed "Show Local Models", and simplified model selection logic.
src/components/Sidebar/auth/index.tsx Updated imports, enhanced state management, replaced submission logic, and removed advanced settings.
src/components/Sidebar/chat/ChangeChatModel.tsx Removed AvailableModels, updated model handling to use models from useChatModels.
src/components/Sidebar/chat/index.tsx Removed AvailableModels import and simplified isVisionModel logic.
src/components/Sidebar/index.tsx Updated rendering logic for Chat and Auth components based on two conditions.
src/config/settings/index.ts Removed AvailableModels enum, changed model type to `string
src/hooks/useChatCompletion.ts Removed AvailableModels, changed model type to string, and simplified instantiation logic.
src/hooks/useChatModels.ts Introduced OpenAIModel type, updated state management, and modified fetching logic.
src/pages/content/sidebar.tsx Removed code for handling modal in chatSettings, updated imports.

Assessment against linked issues

Objective Addressed Explanation
Enable list modals from /modals endpoint rather than list of available modals (#93)

🐇 In the garden where modals bloom,
A patch of syncia clears the gloom.
From /modals they now take flight,
With OpenAI's help, they shine so bright!
No more enums to hold them tight,
Just dynamic names, what a delight! 🌼


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@Royal-lobster Royal-lobster merged commit b6a2378 into main Oct 26, 2024
2 of 3 checks passed
@Royal-lobster Royal-lobster deleted the dynamic-modals branch October 26, 2024 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

Enable list modals from /modals endpoint rather than list of available modals
1 participant