-
Notifications
You must be signed in to change notification settings - Fork 14
Fix: connection.rs error and improve error handling #30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
@@ -1,12 +1,13 @@ | |||
[package] | |||
name = "async-chat" | |||
version = "0.1.0" | |||
edition = "2024" | |||
edition = "2021" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nafisatou you should use the 2024 and not go back to 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nafisatou please ensure your PR passes all the checks
I can see you have formatting issues.
Always try to run the commands in this workflows manually before requesting a pull, that is
- cargo fmt --check
- cargo clippy -- -D warnings
You can also check the workflow to know what it checks in your code
@nafisatou run the ci-local.sh script to check if your code is well formatted before pushing dr |
@nafisatou fix the failing pipeline with |
What This PR Does
connection.rs
by adding explicitResult<()>
typeErr(format!(...))
withanyhow::bail!()
for cleaner error handlingmut
variablesWhy
This ensures that the project compiles properly and improves overall code