Add rust edition feature
#12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CohenArthur
reviewed
Aug 19, 2024
MahadMuhammad
force-pushed
the
feat/add-additional-options
branch
2 times, most recently
from
2a82d33 to
15d5640
Compare
P-E-P
approved these changes
Oct 15, 2024
Signed-off-by: Muhammad Mahad <[email protected]>
Signed-off-by: Muhammad Mahad <[email protected]>
Signed-off-by: Muhammad Mahad <[email protected]>
Signed-off-by: Muhammad Mahad <[email protected]>
Signed-off-by: Muhammad Mahad <[email protected]>
Signed-off-by: Muhammad Mahad <[email protected]>
Signed-off-by: Muhammad Mahad <[email protected]>
Signed-off-by: Muhammad Mahad <[email protected]>
Signed-off-by: Muhammad Mahad <[email protected]>
If the test source file doesn't contain any headers, or that are not added till now then the header value will be None and becomes panic Signed-off-by: Muhammad Mahad <[email protected]>
MahadMuhammad
force-pushed
the
feat/add-additional-options
branch
from
8a33157 to
2e54760
Compare
- in `cli` - converted doc comments to regular comments - in `errors` - added brief macro/fmt for `Error` documentation - Add proper indentation and markdown annotation - in `header` - Called `unwrap` safely - remove unwanted panic, initially this was the replication of rust compile test tool, but this, wasn't unwanted here. See compile test internals https://github.com/rust-lang/rust/blob/d4822c2d84c242cc7403118b50c571464f38ef8f/src/tools/compiletest/src/header.rs#L727 - in `known-directives`: - Add directives link in documentation - in `main`: - remove `unwanted` entry point comment - in `transform`: - Add `TryFrom` for line number casting Signed-off-by: Muhammad Mahad <[email protected]>
|
Thanks for review @P-E-P @CohenArthur, I'll update further PR's once this one will be merged :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
additionaloptions #8Regexvariable for pattern matching #10