jose-jws: remove broken url feature
#75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was never actually declared properly in Cargo.toml and therefore never worked (and therefore this is not actually a breaking change), but also the code behind the feature does not otherwise compile, even if a proper `url` optional dependency is added.
tarcieri
force-pushed
the
jose-jws/remove-url-feature
branch
from
3566b73 to
d97a3b9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was never actually declared properly in Cargo.toml and therefore never worked (and therefore this is not actually a breaking change), but also the code behind the feature does not otherwise compile, even if a proper
urloptional dependency is added.