env variable for version fix

SAFE-Stack · Feb 26, 2024 · a2ce9b0 · a2ce9b0
1 parent 21532d6
commit a2ce9b0
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 6 deletions.
diff --git a/.github/workflows/deploy.yml b/.github/workflows/deploy.yml
@@ -25,7 +25,7 @@ jobs:
     - name: Build
       run: dotnet run bundle
       env:
-        APP_VERSION: ${{ github.ref_name }}
+        VITE_APP_VERSION: ${{ github.ref_name }}
 
     - name: Azure Login
       uses: azure/login@v1

diff --git a/src/Client/index.html b/src/Client/index.html
@@ -15,7 +15,8 @@
     </script>
     <script type="module" src="/output/App.js"></script>
     <script type="module">
-        document.title = document.title.concat(` - v${window.APP_VERSION}`)
+        const appVersion = import.meta.env.VITE_APP_VERSION || "dev"
+        document.title = document.title.concat(` - v${appVersion}`)
     </script>
 
 </body>

diff --git a/src/Client/vite.config.mts b/src/Client/vite.config.mts
@@ -3,7 +3,6 @@ import react from "@vitejs/plugin-react";
 
 const proxyPort = process.env.SERVER_PROXY_PORT || "5000";
 const proxyTarget = "http://localhost:" + proxyPort;
-const appVersion = process.env.APP_VERSION || "dev"
 
 // https://vitejs.dev/config/
 export default defineConfig({
@@ -20,8 +19,5 @@ export default defineConfig({
                 changeOrigin: true,
             }
         }
-    },
-    define: {
-        APP_VERSION: JSON.stringify(appVersion),
     }
 });