Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fix to FAQ for .net9 breaking dotnet watch #369

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

shayanhabibi
Copy link

Issue

Upgrading to .net9 has broken the build process for the SAFE stack by default

What does this pull request address

This pull request adds another section to the FAQ section troubleshoot page which suggests a potential fix should this issue occur in the future with major dotnet releases

How does this pull request address this

Provides the additional command to be passed to Build.fs to allow continued development (without hot-code-reloading stopping despite the name of the argument as is discussed the above referenced issue thread).

Target.create "Run" (fun _ ->
    run dotnet [ "restore"; "Application.sln" ] "."
    run dotnet [ "build" ] sharedPath

    [
        "server", dotnet [ "watch"; "run"; "--no-restore" ; "--no-hot-reload"] serverPath
        "client", dotnet [ "fable"; "watch"; "-o"; "output"; "-s"; "--run"; "npx"; "vite" ] clientPath
    ]
    |> runParallel)

@shayanhabibi
Copy link
Author

My understanding of dotnet and interaction between CLR languages is shallow, but the arguments in the referenced thread seem to refer to --no-hot-reload having nil/negligible impact on F# and other non-C# languages on the CLR.

Would this not be incentive for --no-hot-reload to be default behaviour for the SAFE template?

@isaacabraham
Copy link
Member

@shayanhabibi That has always been the default behaviour of .NET and shouldn't have been changed for .NET 9. My belief is that this will be rolled back / fixed in a patch in the next few weeks.

@shayanhabibi
Copy link
Author

shayanhabibi commented Dec 11, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants