[READY] 2.x - Deprecate idp_cert_fingerprint / idp_cert_fingerprint_algorithm + README cleanup #701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
johnnyshields
commented
Jul 9, 2024
•
johnnyshields
commented
- Deprecate idp_cert_fingerprint and idp_cert_fingerprint_algorithm options (to remove in 2,1.0)
- Improvements to README:
- Edits for clarity & brevity
- Replace terminology "authorization" with "authentication"
- Remove OneLogin references
- Spelling fixes, etc.
- Replace hash rockets with colons
13 tasks
- Edits for clarity & brevity - Replace terminology "authorization" with "authentication" - Remove OneLogin references - Spelling fixes, etc. - Replace hash rockets with colons
johnnyshields
force-pushed
the
patch-4
branch
from
44f601c to
cd9a6f0
Compare
|
@pitbulk this is ready for your final review. Please fix/revert anything you find yourself, no need to run it by me. After merging this, let's release 2.0.0 🎉 I'm already running the latest 2.x branch in production without issues. |
johnnyshields
changed the title
johnnyshields
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.